Skip to content

Conversation

@HannesWell
Copy link
Member

Instead of just suppressing the resource-leakage warnings, tag the methods/fields that leak non-API types as non-api themself.
This is an alternative solution to #1106 (comment) to
get rid of the resource-leakage warnings in the Windows OLE part of SWT.
I think that's the more natural way to resolve this issue and has the advantage that we only temporarily have to add filters to suppress the error that a method/field became non-api.

@iloveeclipse or anybody else, what do you think about that?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Test Results

  118 files  ±0    118 suites  ±0   15m 54s ⏱️ - 1m 1s
4 650 tests ±0  4 633 ✅ ±0  17 💤 ±0  0 ❌ ±0 
  330 runs  ±0    326 ✅ ±0   4 💤 ±0  0 ❌ ±0 

Results for commit 386aef6. ± Comparison against base commit 910f5cd.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the prohibt_non-api_returning_methods branch from 697b16e to 1b6c79d Compare March 15, 2024 18:55
@HannesWell
Copy link
Member Author

Does anybody have an opinion on this?

@HannesWell HannesWell force-pushed the prohibt_non-api_returning_methods branch from 1b6c79d to 59cb971 Compare March 23, 2024 09:57
@akurtakov akurtakov force-pushed the prohibt_non-api_returning_methods branch from 59cb971 to 977394d Compare April 1, 2024 14:05
@akurtakov akurtakov force-pushed the prohibt_non-api_returning_methods branch from 977394d to 3362695 Compare October 30, 2025 20:06
@akurtakov
Copy link
Member

@HeikoKlare What do you think of this one?

@HeikoKlare
Copy link
Contributor

Sounds reasonable to me. I fully agree with:

I think that's the more natural way to resolve this issue and has the advantage that we only temporarily have to add filters to suppress the error that a method/field became non-api.

It will allow us to get rid of most of the API filter for the Windows fragments, which would be really great. And I don't see any risk either, because if someone unexpectedly relies on those methods being API, they will still exist and will still be referencable.

The current failures seem to be caused by the temporary filters for the API removals missing in the aarch64 fragment. @HannesWell do you want to add them so that we may even merge this for the upcoming release and can get rid of all the filters already in December?

@HannesWell HannesWell force-pushed the prohibt_non-api_returning_methods branch from 3362695 to 386aef6 Compare October 31, 2025 18:55
@HannesWell
Copy link
Member Author

This is an old PR.

The current failures seem to be caused by the temporary filters for the API removals missing in the aarch64 fragment. @HannesWell do you want to add them so that we may even merge this for the upcoming release and can get rid of all the filters already in December?

Just done it. And yes, I assume we could then remove them soon.

@HannesWell HannesWell requested review from HeikoKlare and akurtakov and removed request for iloveeclipse and niraj-modi October 31, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants